Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typing with optional fields and open records #41100

Merged
merged 7 commits into from
Aug 15, 2023
Merged

Fix typing with optional fields and open records #41100

merged 7 commits into from
Aug 15, 2023

Conversation

MaryamZi
Copy link
Member

Purpose

$title.

Fixes #40928

Check List

  • Read the Contributing Guide
  • Updated Change Log
  • Checked Tooling Support (#)
  • Added necessary tests
    • Unit Tests
    • Spec Conformance Tests
    • Integration Tests
    • Ballerina By Example Tests
  • Increased Test Coverage
  • Added necessary documentation
    • API documentation
    • Module documentation in Module.md files
    • Ballerina By Examples

@codecov
Copy link

codecov bot commented Jul 27, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.06% ⚠️

Comparison is base (cad922a) 76.43% compared to head (d185a95) 76.38%.
Report is 32 commits behind head on master.

❗ Current head d185a95 differs from pull request most recent head 9a9c189. Consider uploading reports for the commit 9a9c189 to get more accurate results

Additional details and impacted files 
@@             Coverage Diff              @@
##             master   #41100      +/-   ##
============================================
- Coverage     76.43%   76.38%   -0.06%     
+ Complexity    52123    52063      -60     
============================================
  Files          2856     2857       +1     
  Lines        195903   195841      -62     
  Branches      25393    25383      -10     
============================================
- Hits         149747   149600     -147     
- Misses        37858    37948      +90     
+ Partials       8298     8293       -5
Files Changed Coverage Δ
...ava/io/ballerina/runtime/internal/TypeChecker.java 80.98% <100.00%> (+0.04%) ⬆️
...llerinalang/compiler/semantics/analyzer/Types.java 81.80% <100.00%> (+0.03%) ⬆️

... and 40 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarcloud
Copy link

sonarcloud bot commented Aug 14, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell B 7 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@MaryamZi MaryamZi added this to the 2201.8.0 milestone Aug 15, 2023
@MaryamZi MaryamZi marked this pull request as ready for review August 15, 2023 05:11
@MaryamZi MaryamZi merged commit 1417c40 into master Aug 15, 2023
15 of 16 checks passed
@MaryamZi MaryamZi deleted the fix-subtyping-w-optional-fields branch August 15, 2023 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chiranSachintha chiranSachintha chiranSachintha approved these changes

@gimantha gimantha Awaiting requested review from gimantha gimantha is a code owner

@dulajdilshan dulajdilshan Awaiting requested review from dulajdilshan

@lochana-chathura lochana-chathura Awaiting requested review from lochana-chathura

@warunalakshitha warunalakshitha Awaiting requested review from warunalakshitha warunalakshitha is a code owner

@sameerajayasoma sameerajayasoma Awaiting requested review from sameerajayasoma sameerajayasoma is a code owner

@hasithaa hasithaa Awaiting requested review from hasithaa hasithaa is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2201.8.0
Development

Successfully merging this pull request may close these issues.

[Bug]: Invalid type relation for open records with only optional fields
2 participants
@MaryamZi @chiranSachintha